[3666] Enable EMF's intrinsicIDToEObjectMap for JSON resources #3667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pcdavid
force-pushed
the
pcd/enh/enable-intrinsic-id-map
branch
from
d4bc46e to
9211869
Compare
AxelRICHARD
approved these changes
Jun 26, 2024
AxelRICHARD
requested changes
Jun 26, 2024
CHANGELOG.adoc
Outdated
| @@ -67,6 +67,7 @@ More existing APIs will be migrated to this new common pattern. | |||
| - https://github.com/eclipse-sirius/sirius-web/issues/3650[#3650] [diagram] Fix potential NPE in DiagramNavigator and Node toString method | |||
| - https://github.com/eclipse-sirius/sirius-web/issues/3649[#3649] [sirius-web] Restore support for Related elements view icons | |||
| - https://github.com/eclipse-sirius/sirius-web/issues/3630[#3630] [sirius-web] Restore support for the deletion of dangling representations | |||
| - https://github.com/eclipse-sirius/sirius-web/issues/3666[#3666] [core] Enable EMF's entrinsicIDToEObjectMap for JSON resources to support languages which use modeled identifiers (e.g. SysMLv2). | |||
There was a problem hiding this comment.
entrinsicIDToEObjectMap => intrinsicIDToEObjectMap
There was a problem hiding this comment.
Done. Also fixed in the commit message.
This requires moving to EMF JSON 2.3.12 to actually use this new map as a fall back when looking for an object by id. Bug: #3666 Signed-off-by: Pierre-Charles David <[email protected]>
pcdavid
force-pushed
the
pcd/enh/enable-intrinsic-id-map
branch
from
9211869 to
41df985
Compare
AxelRICHARD
changed the title
AxelRICHARD
approved these changes
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will actually require the integration of a new version of EMF JSON with eclipse-sirius/sirius-emf-json#47 in it before it fully works.